python 3.12 support #334
Merged
python 3.12 support #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove references to distutils - app_args.py: add polyfill - setup.py: remove code that hasn't been necessary since 51094d7
for more information, see https://pre-commit.ci
13 tasks
|
Thanks for the patch! Do you think you know what you're doing here? Because I don't when it comes to these packaging things and have no way of verifying because I have no clue what's right and wrong. So I'll have to trust your judgment here. |
|
Also, if you think we should be doing larger cleanup of packaging, feel free to come up with more PRs. The packaging infrastructure of this project is easily 10 years old and hasn't seen much love since then. |
|
FWIW this looks good to me. |
|
And while clean up would be cool, I don't know much about packaging lol. I only submitted this because NixOS updated to 3.12 and it broke my stuff |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove references to distutils
app_args.py: add polyfillsetup.py: remove code that hasn't been necessary since 51094d7