Add options.escape #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
verb decided it wanted to modify some other stuff in the readme, so I let it.
|
thanks! reviewing now
ha, well if verb makes bad choices, please let me know lol. I'd love feedback |
| @@ -21,6 +21,8 @@ module.exports = function(str, options) { | |||
|
|
|||
| var newline = options.newline || '\n' + indent; | |||
|
|
|||
| var escape = options.escape || function(str){return str;}; | |||
There was a problem hiding this comment.
would you mind changing this to:
function identity(str) {
return str;
};
var escape = typeof options.escape === 'function'
? options.escape
: identity;so we can explicitly ensure that escape will always be a function (and not true or something)
|
looks great, and it's a great idea. would you mind making the proposed changes? If not, that's okay I can merge as-is and make the changes - I'm grateful for the pr. |
|
It's not that verb made bad choices, no. I just thought I'd explain why the diff of Readme.md had some unrelated changes in it. |
|
@jonschlinkert Have you had a chance to look at the changes I made? |
|
thanks for the reminder! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this because I was word-wrapping some text that would be embedded in an SVG document. If I escaped it before embedding (a) the lengths would have been wrong, and (b) an entity could be broken across two lines.
verb decided it wanted to modify some other stuff in the readme, so I let it.