Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Form control fields removable token #44359

Open
wants to merge 2 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Oct 27, 2024

Pull Request for Issue # .

Summary of Changes

I had a request to make form token removable for "Form control fields API" .
So here it is.

Testing Instructions

Edit

// Add form control fields
$this->form
->addControlField('task', '')
->addControlField('return', $input->getBase64('return', ''))
->addControlField('forcedLanguage', $forcedLanguage);

And add :

$this->form->removeControlField('joomla.form.token');

Open Article editing form, and check HTML for the from.
The token should be removed.

Actual result BEFORE applying this Pull Request

Field with token is always rendered.
Screenshot 2024-10-27_11-37-48

Expected result AFTER applying this Pull Request

Field with token is removed.
Screenshot 2024-10-27_11-37-11

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org: Form control fields new feature Manual#322
  • No documentation changes for manual.joomla.org needed

Reference:

@Quy
Copy link
Contributor

Quy commented Oct 29, 2024

I have tested this item ✅ successfully on edc60d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44359.

1 similar comment
@fgsw
Copy link

fgsw commented Oct 29, 2024

I have tested this item ✅ successfully on edc60d5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44359.

@alikon
Copy link
Contributor

alikon commented Oct 29, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44359.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants