Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix Multilingual Associations Infinite Loop #44360

Open
wants to merge 8 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

MatMyfta
Copy link

Pull Request for Issue #44224

Summary of Changes

This update implements conditional checks to verify the existence of specified variables before accessing or modifying their values. This enhancement prevents potential runtime errors associated with null or undefined variables.

Testing Instructions

Described in the issue

Actual result BEFORE applying this Pull Request

Described in the issue

Expected result AFTER applying this Pull Request

  • Console errors related to variable access will be resolved.
  • The infinite loop that previously caused the administration console to become unresponsive is eliminated.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@newtastic
Copy link

I have tested this item ✅ successfully on 2b457d3

I tested this with J5.2.0 Stable and it works like excepted now!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

@fgsw
Copy link

fgsw commented Oct 28, 2024

Test by using prebuilt package:

Uncaught TypeError: n.querySelector(...) is null
    <anonymous> https://j44360:8890/media/com_associations/js/sidebyside.min.js?983476:4
    <anonymous> https://j44360:8890/media/com_associations/js/sidebyside.min.js?983476:4

44360

@MatMyfta
Copy link
Author

What prebuilt package are you testing?
The changes are made on the build directory, so all the resources in media have to be rebuild with the new changes.

@fgsw
Copy link

fgsw commented Oct 28, 2024

The changes are made on the build directory

Had only looked at the prebuild package at the end of the Pull Request and not at the Directory-Path if it contain build.

Would be better in cases like this to not offer prebuilt packages.

@Quy
Copy link
Contributor

Quy commented Oct 28, 2024

Installed the pre-built package:

44360-multilingual

@Quy
Copy link
Contributor

Quy commented Oct 30, 2024

Still an issue:

44360-multilingual

@Quy
Copy link
Contributor

Quy commented Oct 31, 2024

44360-multilingual2

@Quy
Copy link
Contributor

Quy commented Nov 7, 2024

I have tested this item ✅ successfully on cdad048


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on cdad048


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44360.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants