Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added customNetwork to TokensFactoryPublic constructor, Added option to skip the quote observer, Removed Ropsten Chain #55

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

niZmosis
Copy link

@niZmosis niZmosis commented Nov 14, 2022

Added customNetwork to TokensFactoryPublic:
Fix for issue #41
Added a playground method for testing getAllowanceAndBalanceOfForContracts on a custom network

Added option to skip the quote observer:
Option to prevent the library from adding the block listener, as when it's finished it removes all listeners of 'block', which may affect front end dApps. When true, It's up to the dev to listen for new blocks and update the quote using the new requote function on the UniswapPairFactory obj.

Bound the block listener which observes the quote, to its class instance. This will prevent all block listeners from being removed when a quote is destroyed. There may be a way to make the binding async, but I'm not sure.

Removed Ropsten Chain: Ropsten Chain has been deprecated
Removed Rinkeby Chain: Rinkeby Chain has been deprecated
Removed Kovan Chain: Kovan Chain has been deprecated
Added Sepolia Chain: WIP by Uniswap team to deploy the contracts on this chain still.

niZmo added 3 commits November 13, 2022 20:54
Added option to skip the quote watcher
Removed Ropsten Chain
Renamed disableWatcher to disableObserver
@niZmosis
Copy link
Author

@joshstevens19 Hey, could you review this PR when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant