Include filename in input parse error message #3146
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wader
commented
Jun 30, 2024
| 456 | ||
| EOF | ||
| cat > $d/expected_err <<EOF | ||
| jq: parse error (at $d/input_error_line2:2): Invalid numeric literal at line 4, column 0 |
There was a problem hiding this comment.
line 4 here is a bit confusing, i guess that is counting lines from all input files seen so far
wader
commented
Jun 30, 2024
| jq: ignoring parse error: Truncated value at line 3, column 1 | ||
| jq: ignoring parse error (at <stdin>:2): Truncated value at line 2, column 5 | ||
| jq: ignoring parse error (at <stdin>:2): Truncated value at line 2, column 25 | ||
| jq: ignoring parse error (at <stdin>:2): Truncated value at line 3, column 1 |
There was a problem hiding this comment.
Here it's at <stdin>:2 and line 3 hmm, haven dugg much but i guess it's start of new value vs where it ended somehow?
wader
commented
Jun 30, 2024
| EOF | ||
| printf '1\0362 3\n[0,1\036[4,5]true"ab"{"c":4\036{}{"d":5,"e":6"false\n\036null'|$VALGRIND $Q $JQ -ces --seq '. == [2,3,[4,5],true,"ab",{},null]' > /dev/null 2> $d/out | ||
| cmp $d/out $d/expected | ||
|
|
||
| # Note that here jq sees no inputs at all but it still succeeds because | ||
| # --seq ignores parse errors | ||
| cat > $d/expected <<EOF | ||
| jq: ignoring parse error: Unfinished abandoned text at EOF at line 1, column 4 | ||
| jq: ignoring parse error (at <stdin>:0): Unfinished abandoned text at EOF at line 1, column 4 |
There was a problem hiding this comment.
Should probably be <stdin>:1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1553