Fix typos #3173
Merged
Fix typos #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
reviewed
Sep 11, 2024
src/decNumber/decBasic.c
Outdated
| @@ -113,7 +113,7 @@ static decFloat * decCanonical(decFloat *result, const decFloat *df) { | |||
| #endif | |||
| } // block | |||
|
|
|||
| // Loop to repair a non-canonical coefficent, as needed | |||
There was a problem hiding this comment.
This is a third-party library, so please drop the changes, and report to the upstream if you can.
There was a problem hiding this comment.
Ah, I didn't realise. I'm used to seeing copied dependencies in "vendor" or "third_party" folders.
itchyny
reviewed
Sep 12, 2024
| @@ -207,7 +207,7 @@ body: | |||
| "name": "Nico Williams" | |||
| } | |||
| { | |||
| "message": "Fix iterration problem for non decimal string\n\nWhen the string transformation to number failed, all following\ntransformation failed too.\n\nThis happend because status in decNumberFromString function is\nupdated just in error case. Reusing the DEC_CONTEXT that failed\nbefore results into error even if the string is valid number.", | |||
| "message": "Fix iteration problem for non decimal string\n\nWhen the string transformation to number failed, all following\ntransformation failed too.\n\nThis happend because status in decNumberFromString function is\nupdated just in error case. Reusing the DEC_CONTEXT that failed\nbefore results into error even if the string is valid number.", | |||
There was a problem hiding this comment.
Are you aware that this is a commit message of this repository? Fixing typos like this example looks not just meaningless, but lacks well investigation of the context.
There was a problem hiding this comment.
I'm not trying to waste anybody's time, I saw a typo in an OSS project that I like and I fixed it.
I agree that this PR is far less "meaningful" now that the decNumber fixes are out of scope - feel free to close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just thought I'd contribute some typo fixes to this useful project, nothing controversial (hopefully).
Use the following command to get a quick and dirty summary of the specific corrections made:
FWIW, the typos are: