Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update @jspm/[email protected] #24

Merged
merged 2 commits into from
Dec 22, 2023
Merged

chore: Update @jspm/[email protected] #24

merged 2 commits into from
Dec 22, 2023

Conversation

JayaKrishnaNamburu
Copy link
Member

Chore

Update the @jspm/generator to the latest version

@JayaKrishnaNamburu
Copy link
Member Author

@yowainwright any thoughts on the CI failure for the ensureDirSync now. The tests seems to work for me in local

@yowainwright
Copy link
Member

@JayaKrishnaNamburu do we need to do something new to create the .cache/ directory in the Github action with @jspm/[email protected]?

@JayaKrishnaNamburu
Copy link
Member Author

I don't think they are related, maybe ensureDirSync is not creating the nested paths in the path now. If missing, and checking only the last folder/file from given path ?

@yowainwright
Copy link
Member

yowainwright commented Dec 11, 2023 •
edited
Loading

@JayaKrishnaNamburu you're onto something

Will fix when I can!

yowainwright
yowainwright approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@yowainwright yowainwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good-to-go @JayaKrishnaNamburu 🔥

@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this Dec 22, 2023
@JayaKrishnaNamburu JayaKrishnaNamburu merged commit 71b8681 into main Dec 22, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yowainwright yowainwright yowainwright approved these changes

Assignees

@JayaKrishnaNamburu JayaKrishnaNamburu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayaKrishnaNamburu @yowainwright