-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module author feedback #717
Comments
@panva Thank you for the feedback. I have opened a PR to address a couple of the issues you had: #726 On your questions:
Yes, you can "yank" it from the versions page. https://jsr.io/docs/packages#yanking-versions
Not yet, but it is on the roadmap. #250
No, see https://jsr.io/docs/immutability. We may consider adding a way to unpublish a module within a couple of hours of release, taking into account download stats. But this feature does not exist yet.
Latest by semver, excluding pre-releases.
This looks like a bug. I opened #724.
What would you expect these to do? I am thinking the following:
What are some examples of groups you'd like to show?
That is now fixed. It was a bug!
Right now we do indeed link all paths to the relevant files on JSR. Always linking them to GitHub does not work for us - users do not have to link a JSR package to GitHub. We could do a fallback mechanism though: either we link to JSR source if the file exists, or to GitHub if that is specified, or it is a dead link. However, there is relatively little reason for you not to publish examples and docs to JSR. Consumers using native JSR imports only pull in files that are (transitively) linked to from their code. If you have a package with 1 code file, and 300 examples, then any user of this package in (for example) Deno, would only pull in the 1 code file. The 300 examples never make it onto their machine. |
@lucacasonato thank you for taking the time to respond and taking care of splitting things up for you internally.
Yup, like it is done here.
This very page shows how groups are used to transform JSDoc
Cheers.
Great.
Thank you, a fallback to github, even if by opt-in in the deno.json conf file would work.
Except that I will have to maintain the extra fluff to conform to JSRs publishing rules, lint rules, score evaluations etc. |
- **fix: mention deno publish in GHA linking docs** - **fix: improve wording on docs part of JSR score** See #717
…nt (#734) For #717 > We could do a fallback mechanism though: either we link to JSR source if the file exists, or to GitHub if that is specified, or it is a dead link. _Originally posted by @lucacasonato in #717 (comment) --------- Co-authored-by: Yoshiya Hinosawa <[email protected]>
So I gave jsr.io some time to cook since its initial release and now gave it a fair shot. Here's feedback as to the experience I had and some issues I'm seeing.
I come from a place where I will not abandon established registries and distribution means for jsr.io, jsr.io is a complementary distribution for a module.
I've published https://github.com/panva/oauth4webapi -> https://jsr.io/@panva/oauth4webapi
The publishing
I went straight to a GHA workflow. Setting everything up was straight forward and publishing came through on a first try.
In the "How to publish" page on jsr.io I was told that "You will need to run
deno publish
in your action." but then all the steps told me to usenpx jsr publish
instead. This confused me. I don't understand the difference between the two and nor do I want to.Screenshot
The registry
I only have questions here
The package Web UI - Score
I don't know if
Has docs for most symbols
is looking for all symbols or just the exported ones. I assume the latter but a simple wording change would suffice to resolve this.I'd like the score checks to be included in the CLI so that I can check them before publishing.
The package Web UI - docs
The
optional
andreadonly
property tags are sorted random, why?Screenshot
The JSDoc
@see
and@group
tags are not used in the UI at all.The package Web UI - "Use with"
ERR_PACKAGE_PATH_NOT_EXPORTED
error) because the trailing "/" in the import is a subpath export (./
) which obviously isn't in the package.json file (.
is,./
isn't). FWIW, another question - how would I even define subpath exports for Node.js users in the jsr.json config file?The package Web UI - README - biggest offender
Absolutely horrible, all relative links on npmjs.org are resolved using the package's homepage (or repository?). On jsr.io relative links lead to a 404 because the files are not in the published package (intentionally), why would i publish example typescript files?. I don't want to maintain two README files so the registry needs to be smart enough to point to the repository for relative links in the README file it renders.
The text was updated successfully, but these errors were encountered: