Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make links relative to github for readme if github repo is present #734

Merged
merged 3 commits into from
Sep 19, 2024
Merged

fix: make links relative to github for readme if github repo is present #734

merged 3 commits into from
Sep 19, 2024

Conversation

crowlKats
Copy link
Collaborator

@crowlKats crowlKats commented Sep 19, 2024 •
edited
Loading

For #717

We could do a fallback mechanism though: either we link to JSR source if the file exists, or to GitHub if that is specified, or it is a dead link.

Originally posted by @lucacasonato in #717 (comment)

@crowlKats @kt3k
add coauthor
aa4ebdb 
Co-authored-by: Yoshiya Hinosawa <[email protected]>
lucacasonato
lucacasonato reviewed Sep 19, 2024
View reviewed changes
api/src/db/models.rs Outdated Show resolved Hide resolved
lucacasonato
lucacasonato approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crowlKats crowlKats added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit 10abe40 Sep 19, 2024
6 checks passed
@crowlKats crowlKats deleted the link-to-github-for-readme-if-github-repo-is-present branch September 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucacasonato lucacasonato lucacasonato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crowlKats @lucacasonato