Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract Attr's marshal and unmarshal from baseMeta to Attr #5638

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shenxingwuying
Copy link

I think the Attr's marshal and unmarshal in Attr is better than baseMeta. Maybe some other basic structure need review later.

@CLAassistant
Copy link

CLAassistant commented Feb 10, 2025

CLA assistant check
All committers have signed the CLA.

@shenxingwuying shenxingwuying force-pushed the dev/refact_marshal_unmarshal branch from 19d86ef to 8e08af2 Compare February 10, 2025 10:48
@shenxingwuying shenxingwuying force-pushed the dev/refact_marshal_unmarshal branch from 8e08af2 to af9a9c5 Compare February 10, 2025 12:37
@jiefenghuang
Copy link
Contributor

jiefenghuang commented Feb 12, 2025

Hi @shenxingwuying
Do you need to reference this function? Currently, there’s no need to expose this function.

@davies davies requested a review from jiefenghuang February 13, 2025 05:06
@shenxingwuying
Copy link
Author

Hi @shenxingwuying Do you need to reference this function? Currently, there’s no need to expose this function.

I‘m planning to add a new meta service plugin to make some operations can push to it,
and it's a better way to keep the storage format in juicefs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants