Better to keep context.WithValue
constant
#5665
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In stdlib,
context.WithValue
returns a derived context that points to the parentContext
, and the parentContext
is not modified.In JuiceFS,
context.WithValue
mutates itself by stacking theContext
field. This is error-prone as no one can clean the stack chain.Especially in the
gateway
scenario wheremeta.Context
is a global variable - its value chain can grow infinitely asgateway
runs long enough. This causes a memory leak and makes searching for a non-existent key very expensive.It's better to follow best practices in the Go community.