Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace arrayContains with build-in Array.includes function #805

Open
wants to merge 1 commit into
base: v3.3.0
Choose a base branch
from
Open

feat: replace arrayContains with build-in Array.includes function #805

wants to merge 1 commit into from

Conversation

tkgroot
Copy link

@tkgroot tkgroot commented Feb 11, 2022

replace helper function arrayContains with build-in Array.includes function

@Pulse-Git
Copy link

@tkgroot not supported by IE11

@tkgroot
Copy link
Author

tkgroot commented Aug 2, 2022

Maybe a good idea to drop IE11 support or let it be handled by polyfills?
Also if you look ahead IE11 doesn't support ESM, so it's just a big hurdle to keep the support for it

@tkgroot tkgroot force-pushed the feat/replace-array-contains branch from 6bad8f7 to 3cc6858 Compare January 4, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkgroot @Pulse-Git