Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Google Artifact Registry #1936

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add support for Google Artifact Registry #1936

wants to merge 4 commits into from

Conversation

paololazzari
Copy link
Contributor

Fixes #1934

@consideRatio consideRatio mentioned this pull request Mar 5, 2025
Open
@paololazzari paololazzari reopened this Mar 10, 2025
@paololazzari
Copy link
Contributor Author

This pull requests allows for the GCP's Google Metadata Server to be used as a token_url:

config:
  BinderHub: 
    DockerRegistry:
      url: "https://us-central1-docker.pkg.dev"
      token_url: http://metadata.google.internal/computeMetadata/v1/instance/service-accounts/default/token
      username: "oauth2accesstoken"

@paololazzari
Copy link
Contributor Author

@consideRatio could you take a look please? this change is the only way I can get binderhub to work with artifact registry

@paololazzari
Copy link
Contributor Author

@rgaiacs could you take a look please?

@consideRatio
Copy link
Member

@paololazzari Sorry I am too low on time to help at the moment =/

@rgaiacs
Copy link
Contributor

rgaiacs commented Mar 31, 2025

could you take a look please?

I never used Google Compute Engine. I cannot help. Sorry.

@paololazzari
Copy link
Contributor Author

Is there anyone who can help? it's a very small change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tornado.httpclient.HTTPClientError: HTTP 401: Unauthorized for GCP service account which works locally
3 participants
@paololazzari @consideRatio @rgaiacs