Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Shouldly #47

Merged
merged 4 commits into from
Jan 15, 2025
Merged

Migrate to Shouldly #47

merged 4 commits into from
Jan 15, 2025

Conversation

martincostello
Copy link
Member

  • Migrate tests from FluentAssertions to Shouldly.
  • Sort package references.
  • Add EditorConfig file.

@martincostello
Migrate to Shouldly
3022eda 
- Migrate tests from FluentAssertions to Shouldly.
- Sort package references.
- Add EditorConfig file.
@martincostello martincostello added enhancement New feature or request dependencies Pull requests that update a dependency file .NET Pull requests that update .net code labels Jan 15, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.70%. Comparing base (3e646b8) to head (2fe3bff).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main      #47   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files          16       16           
  Lines        1356     1356           
  Branches      178      178           
=======================================
  Hits          891      891           
  Misses        465      465
Flag Coverage Δ
linux 65.70% <ø> (ø)
macos 65.70% <ø> (ø)
windows 65.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Fix tests
93c0492 
Fix some tests.
@martincostello
Fix test
159a93a 
Make assertions case insensitive between unit and verification tests.
@martincostello martincostello marked this pull request as ready for review January 15, 2025 10:02
slang25
slang25 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@slang25 slang25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions

tests/LocalSqsSnsMessaging.Tests.Shared/SnsPublishAsyncTests.cs Outdated Show resolved Hide resolved
tests/LocalSqsSnsMessaging.Tests.Shared/SnsPublishAsyncTests.cs Outdated Show resolved Hide resolved
@martincostello martincostello merged commit 2cfcbe8 into main Jan 15, 2025
7 checks passed
@martincostello martincostello deleted the shouldly branch January 15, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slang25 slang25 slang25 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request .NET Pull requests that update .net code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martincostello @slang25