Add uncontrolled form to the nextjs example #224
+67
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React, there are two ways to build forms:
Our Next.js app already has a working example of the first approach, but we're missing implementation for the second approach—where users can access the form data upon submission similar to the Vanilla JS example we have here, so ideally we should fully test and support both ways.
🐛 Blocker
While trying to add the uncontrolled form example, I noticed that the React-wrapped version of our form components doesn't correctly attach/read the form element's value when the form is submitted, even though we're using the element-internals-polyfill.
The issue doesn’t happen when using the custom element directly in React or Vanilla JS so my rough assumption is the issue might be related to
@lit/react
Screen.Recording.2024-10-28.at.17.30.02.mov
⏭️ Next step
Ensure the issue isn't from our side and reach out to the lit team if needed.