released 4.2.0

k0shk0sh · Sep 9, 2017 · b617b80 · b617b80
1 parent 96b8fba
commit b617b80
Show file tree

Hide file tree

Showing 10 changed files with 73 additions and 157 deletions.
diff --git a/.github/check_translations.cs b/.github/check_translations.cs
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
-[![Build Status](https://travis-ci.org/k0shk0sh/FastHub.svg?branch=master)](https://travis-ci.org/k0shk0sh/FastHub) [![Build status](https://ci.appveyor.com/api/projects/status/2yhxx7hu6hju24bk?svg=true)](https://ci.appveyor.com/project/k0shk0sh/fasthub)
+[![Build Status](https://travis-ci.org/k0shk0sh/FastHub.svg?branch=master)](https://travis-ci.org/k0shk0sh/FastHub)
 [![Releases](https://img.shields.io/github/release/k0shk0sh/FastHub.svg)](https://github.com/k0shk0sh/FastHub/releases/latest) [![Slack](https://img.shields.io/badge/slack-join-e01563.svg)](http://rebrand.ly/fasthub)
 
 ![Logo](/.github/assets/feature_graphic.png?raw=true "Logo")
@@ -18,10 +18,6 @@ Yet another **open-source** GitHub client app but unlike any other app, FastHub
       alt="Direct apk download"
       height="80">](https://github.com/k0shk0sh/FastHub/releases/latest)
 
-#### Snapshots / Test builds
-
-We have configured snapshots of FastHub, which can be downloaded from [AppVeyor CI](https://ci.appveyor.com/project/k0shk0sh/fasthub/build/artifacts).
-
 # Features  
 - **App**
   - Three login types (Basic Auth), (Access Token) or via (OAuth)

diff --git a/app/build.gradle b/app/build.gradle
@@ -96,6 +96,7 @@ android {
 
     dexOptions {
         jumboMode true
+        javaMaxHeapSize "4g"
     }
 
     testOptions {

diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro
@@ -130,4 +130,5 @@
 -dontwarn sun.misc.Unsafe
 -dontwarn com.octo.android.robospice.retrofit.RetrofitJackson**
 -dontwarn retrofit.appengine.UrlFetchClient
--dontwarn icepick.**
+-dontwarn icepick.**
+-dontwarn com.fastaccess.ui.modules.repos.**
diff --git a/app/src/main/java/com/fastaccess/provider/timeline/handler/drawable/DrawableGetter.java b/app/src/main/java/com/fastaccess/provider/timeline/handler/drawable/DrawableGetter.java
@@ -18,7 +18,7 @@
  * Created by Kosh on 22 Apr 2017, 7:44 PM
  */
 
-public class DrawableGetter implements Html.ImageGetter {
+public class DrawableGetter implements Html.ImageGetter, Drawable.Callback {
     private WeakReference<TextView> container;
     private final Set<GlideDrawableTarget> cachedTargets;
 
@@ -42,6 +42,16 @@ public DrawableGetter(TextView tv) {
         return urlDrawable;
     }
 
+    @Override public void invalidateDrawable(@NonNull Drawable drawable) {
+        if (container != null && container.get() != null) {
+            container.get().invalidate();
+        }
+    }
+
+    @Override public void scheduleDrawable(@NonNull Drawable drawable, @NonNull Runnable runnable, long l) {}
+
+    @Override public void unscheduleDrawable(@NonNull Drawable drawable, @NonNull Runnable runnable) {}
+
     public void clear(@NonNull DrawableGetter drawableGetter) {
         if (drawableGetter.cachedTargets != null) {
             for (GlideDrawableTarget target : drawableGetter.cachedTargets) {

diff --git a/app/src/main/java/com/fastaccess/provider/timeline/handler/drawable/UrlDrawable.java b/app/src/main/java/com/fastaccess/provider/timeline/handler/drawable/UrlDrawable.java
@@ -3,15 +3,23 @@
 import android.graphics.Canvas;
 import android.graphics.drawable.BitmapDrawable;
 import android.graphics.drawable.Drawable;
+import android.support.annotation.NonNull;
 
-class UrlDrawable extends BitmapDrawable {
+import com.bumptech.glide.load.resource.gif.GifDrawable;
+
+class UrlDrawable extends BitmapDrawable implements Drawable.Callback {
     private Drawable drawable;
 
     @SuppressWarnings("deprecation") UrlDrawable() {}
 
     @Override public void draw(Canvas canvas) {
         if (drawable != null) {
             drawable.draw(canvas);
+            if (drawable instanceof GifDrawable) {
+                if (!((GifDrawable) drawable).isRunning()) {
+                    ((GifDrawable) drawable).start();
+                }
+            }
         }
     }
 
@@ -20,6 +28,28 @@ public Drawable getDrawable() {
     }
 
     public void setDrawable(Drawable drawable) {
+        if (this.drawable != null) {
+            this.drawable.setCallback(null);
+        }
+        drawable.setCallback(this);
         this.drawable = drawable;
     }
+
+    @Override public void invalidateDrawable(@NonNull Drawable who) {
+        if (getCallback() != null) {
+            getCallback().invalidateDrawable(who);
+        }
+    }
+
+    @Override public void scheduleDrawable(@NonNull Drawable who, @NonNull Runnable what, long when) {
+        if (getCallback() != null) {
+            getCallback().scheduleDrawable(who, what, when);
+        }
+    }
+
+    @Override public void unscheduleDrawable(@NonNull Drawable who, @NonNull Runnable what) {
+        if (getCallback() != null) {
+            getCallback().unscheduleDrawable(who, what);
+        }
+    }
 }
diff --git a/app/src/main/java/com/fastaccess/ui/modules/repos/RepoPagerActivity.java b/app/src/main/java/com/fastaccess/ui/modules/repos/RepoPagerActivity.java
@@ -39,6 +39,7 @@
 import com.fastaccess.helper.ViewHelper;
 import com.fastaccess.provider.colors.ColorsProvider;
 import com.fastaccess.provider.scheme.LinkParserHelper;
+import com.fastaccess.provider.scheme.SchemeParser;
 import com.fastaccess.provider.tasks.git.GithubActionService;
 import com.fastaccess.ui.adapter.TopicsAdapter;
 import com.fastaccess.ui.base.BaseActivity;
@@ -529,7 +530,7 @@ public static Intent createIntent(@NonNull Context context, @NonNull String repo
         } else if (item.getItemId() == R.id.originalRepo) {
             if (getPresenter().getRepo() != null && getPresenter().getRepo().getParent() != null) {
                 Repo parent = getPresenter().getRepo().getParent();
-                RepoPagerActivity.startRepoPager(this, new NameParser(parent.getHtmlUrl()));
+                SchemeParser.launchUri(this, parent.getHtmlUrl());
             }
             return true;
         } else if (item.getItemId() == R.id.deleteRepo) {

diff --git a/app/src/main/res/raw/changelog.html b/app/src/main/res/raw/changelog.html
@@ -13,13 +13,15 @@ <h3><a id="Version__420_Create_Edit__Delete_files_make_Commits_2"></a>Version 4.
         <blockquote>
             <p>Reporting Issues or Feature Requests in Google Play review section, will be ignored or might even get your account to be blocked from
                 FastHub. You are using an app for GitHub, which provides a proper way to report issues.
-                Please report the issues in FastHub repo instead, by opening the Drawer Menu, click about and click "Report an Issue" PLEASE USE IT.
+                <br>
+                Please report the issues in FastHub repo instead, by opening the Drawer Menu, click about and click “Report an Issue”<strong>PLEASE
+                    USE IT</strong>.
             </p>
         </blockquote>
-        <h4><a id="Bugs__Enhancements__new_Features_320_6"></a>Bugs , Enhancements &amp; new Features (3.2.0)
+        <h4><a id="Bugs__Enhancements__new_Features_320_7"></a>Bugs , Enhancements &amp; new Features (3.2.0)
         </h4>
         <ul>
-            <li>(New) Make commits on repos from FastHub (this only applies for repo owners so far)
+            <li>(New) Make commits on repos from FastHub (this only applies for repo owners so far).
                 <strong>PRO</strong>
             </li>
             <li>(New) Long pressing files/directories will open up their Commit/Git History.</li>
@@ -33,37 +35,35 @@ <h4><a id="Bugs__Enhancements__new_Features_320_6"></a>Bugs , Enhancements &amp;
             <li>(Enhancement) Hide fab while scrolling in Issues &amp; PR tab.</li>
             <li>(Fix) PR Status where it got somehow broken in previous release.</li>
             <li>(Fix) A text under PR status will indicates if the PR is mergable or not.</li>
+            <li>(Fix) Tagging users in full screen editor.</li>
             <li>(Fix) Comments text selection where sometime they aren’t selectable.</li>
-            <li>(Fix) PR Review footer is invisible in (4.1.0)</li>
+            <li>(Fix) PR Review footer is invisible in (4.1.0).</li>
             <li>(Fix) Cursor position after inserting emoji, links &amp; images.</li>
-            <li>(Fix) Teal customized accent was displayed as green</li>
+            <li>(Fix) Teal customized accent was displayed as green.</li>
             <li>(Fix) Some crashes from the crash report.</li>
-            <li>(Fix) Lots of bug fixes</li>
-            <li>There are more stuff are not mentioned, find them out :p</li>
+            <li>(Fix) Lots of bug fixes.</li>
+            <li>There are more stuff are not mentioned, find them out :stuck_out_tongue:</li>
         </ul>
-        <h4><a id="What_left_in_FastHub_28"></a>What left in FastHub?
-        </h4>
-        <p>So far, FastHub has almost all the features from GitHub except for
-            <strong>Project Cards</strong>
-            next release will hopefully includes that &amp;
-            then I’ll be only releasing when major bugs is fixed or major feature implemented.
-        </p>
-        <h3><a id="How_old_is_FastHub_now_31"></a>How old is FastHub now?
+        <h3><a id="What_left_in_FastHub_29"></a>What left in FastHub?
         </h3>
         <blockquote>
-            <p>FastHub is now 5 months &amp; 4 days old, since v1.0.0 it has really grow and became more and more better on each release and this is
-                all
-                happened because of the community either via reporting bugs, feature requests or even give hand to fix things or implement things in
-                the app,
-                I’m really grateful for such community, thank you guys a lot.
+            <p>
+                <strong>So far, FastHub has implemented almost all the features of GitHub, besides for<strong>Project Cards</strong>. Hopefully in the
+                    next release FastHub will include that. The following releases will mainly be bug fixes or if a major feature is implemented.
+                </strong>
             </p>
         </blockquote>
+        <h3><a id="How_old_is_FastHub_now_33"></a>How old is FastHub now?
+        </h3>
         <blockquote>
-            <p>Thanks to everyone who contributed either via reporting bugs or via code contribution</p>
+            <p>
+                <strong>FastHub is now 5 months &amp; a week old. Since v1.0.0 it has really grow with each and every release. The only way this was
+                    possible, was due to the community helping out either via reporting bugs, feature requests or even give hand to fix things or
+                    implement things in the app. I’m really grateful for having such a great community. Thank you guys!
+                </strong>
+            </p>
         </blockquote>
-        <p>
-            <strong>Thank you very much</strong>
-        </p>
+        <p>Thank you to all who have contributed either via reporting bugs or via code contribution.</p>
 
     </body>
 </html>
diff --git a/appveyor.yml b/appveyor.yml
diff --git a/build.gradle b/build.gradle
@@ -22,7 +22,7 @@ buildscript {
         google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.0.0-beta2'
+        classpath 'com.android.tools.build:gradle:3.0.0-beta5'
         classpath 'com.google.gms:google-services:3.0.0'
         classpath 'com.novoda:gradle-build-properties-plugin:0.3'
         classpath 'com.dicedmelon.gradle:jacoco-android:0.1.2'