add mandatory type argument in iq's constructor

according to RFC type attribute is mandatory, so it makes sense to make it mandatory argument when constructing query

Component/Binding.php

@@ -39,7 +39,7 @@ public function setClient(XmppClient $client)
     public function bind(Features $features)
     {
         if($features->has(with\element('bind', self::XMLNS))) {
-            $stanza = new Iq(['type' => 'set']);
+            $stanza = new Iq('set');
             $bind = $stanza->append(new Iq\Query(self::XMLNS, 'bind'));
 
             if(!$this->_client->jid->isBare()) {

Component/PingKeepAlive.php

@@ -62,7 +62,7 @@ public function disable()
 
     private function keepAlive()
     {
-        $ping = new Iq(['type' => 'get', 'query' => new Iq\Query('urn:xmpp:ping', 'ping')]);
+        $ping = new Iq('get', ['query' => new Iq\Query('urn:xmpp:ping', 'ping')]);
 
         $this->_client->write($ping);
     }

Stanza/Iq.php

@@ -31,6 +31,7 @@ class Iq extends Stanza
 {
     /**
      * Stanza constructor.
+     * @param string $type Iq query type
      * @param array  $options {
      *     @var Jid     $from      Jid representing "from" stanza attribute
      *     @var Jid     $to        Jid representing "to" stanza attribute
@@ -41,8 +42,9 @@ class Iq extends Stanza
      *     @var Query   $query     Query associated with stanza
      * }
      */
-    public function __construct(array $options)
+    public function __construct(string $type, array $options = [])
     {
+        $this->type = $type;
         parent::__construct('iq', $options);
     }
 

Tests/Modules/BindingTest.php

@@ -106,9 +106,8 @@ public function testBindingInitiationWithResourceFailure()
     public function success($id, $resource = 'generated')
     {
         $jid = "[email protected]/$resource";
-        $result = new Iq([
-            'type' => 'result',
-            'id'   => $id,
+        $result = new Iq('result', [
+            'id'    => $id,
             'query' => new Iq\Query('urn:ietf:params:xml:ns:xmpp-bind', 'bind', [
                 'content' => new XmlElement('jid', null, ['content' => $jid])
             ])
@@ -120,7 +119,7 @@ public function success($id, $resource = 'generated')
 
     public function failure($id, Error $error)
     {
-        $result = new Iq(['type' => 'error', 'id' => $id, 'content' => $error]);
+        $result = new Iq('error', ['id' => $id, 'content' => $error]);
         $this->_client->emit('element', [ $result ]);
     }
 

Xml/XmlElement.php

@@ -594,4 +594,24 @@ public static function cast(XmlElement $element)
 
         return $return;
     }
+
+    /**
+     * When an object is cloned, PHP 5 will perform a shallow copy of all of the object's properties.
+     * Any properties that are references to other variables, will remain references.
+     * Once the cloning is complete, if a __clone() method is defined,
+     * then the newly created object's __clone() method will be called, to allow any necessary properties that need to be changed.
+     * NOT CALLABLE DIRECTLY.
+     *
+     * @link http://php.net/manual/en/language.oop5.cloning.php
+     */
+    public function __clone()
+    {
+        $children = $this->_children;
+        $this->_children = [];
+        $this->_parent = null;
+
+        foreach ($children as $child) {
+            $this->append(is_object($child) ? clone $child : $child);
+        }
+    }
 }

composer.json

@@ -17,7 +17,7 @@
     "evenement/evenement": "2.0.*",
     "psr/log": "1.0.*",
     "kadet/keylighter": "^0.8",
-    "fabiang/sasl": "dev-rspauth",
+    "fabiang/sasl": "dev-rspauth@dev",
     "php-di/php-di": "^5.3"
   },
   "require-dev": {

ruleset.xml

@@ -31,7 +31,7 @@
     </rule>
     <rule ref="rulesets/naming.xml/ShortMethodName">
         <properties>
-            <property name="exceptions" value="id,on,is" />
+            <property name="exceptions" value="id,on,is,to,as" />
         </properties>
     </rule>