Merge pull request #2661 from Fork-World/2660-fail_annotation_in_xml_…

…report #2660 fail annotation in xml report
karatelabs · Mar 3, 2025 · f84b6d6 · f84b6d6
2 parents 41c0454 + 6c18e0c
commit f84b6d6
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/karate-core/src/main/java/com/intuit/karate/report/ReportUtils.java b/karate-core/src/main/java/com/intuit/karate/report/ReportUtils.java
@@ -216,7 +216,7 @@ public static File saveJunitXml(String targetDir, FeatureResult result, String f
             testCase.setAttribute("name", name);
             testCase.setAttribute("time", formatter.format(sr.getDurationMillis() / 1000));
             Element stepsHolder;
-            if (error != null) {
+            if (error != null && sr.isFailed()) {
                 stepsHolder = doc.createElement("failure");
                 stepsHolder.setAttribute("message", error.getMessage());
             } else {

diff --git a/karate-core/src/test/java/com/intuit/karate/report/ReportUtilsTest.java b/karate-core/src/test/java/com/intuit/karate/report/ReportUtilsTest.java
@@ -81,5 +81,25 @@ void testCustomTags() {
         File file = ReportUtils.saveJunitXml("target", fr.result, null);
         assertTrue(FileUtils.toString(file).contains(expectedCustomTags));
     }
+
+    @Test
+    void testFailAnnotationXML() {
+    	String expectedSystemout = "<system-out>"; 
+        Feature feature = Feature.read("classpath:com/intuit/karate/core/fail-tag.feature");
+        FeatureRuntime fr = FeatureRuntime.of(new Suite(), new FeatureCall(feature));
+        fr.run();
+        File file = ReportUtils.saveJunitXml("target", fr.result, null);
+        assertTrue(FileUtils.toString(file).contains(expectedSystemout));
+    }
+
+    @Test
+    void testFailAnnotationXMLFailure() {
+    	String expectedSystemout = "<failure"; 
+        Feature feature = Feature.read("classpath:com/intuit/karate/core/fail-tag-failure.feature");
+        FeatureRuntime fr = FeatureRuntime.of(new Suite(), new FeatureCall(feature));
+        fr.run();
+        File file = ReportUtils.saveJunitXml("target", fr.result, null);
+        assertTrue(FileUtils.toString(file).contains(expectedSystemout));
+    }
 
 }