Upgrade json-smart from 2.5.1 to 2.5.2 fixing CVE-2024-57699 #2663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For details about CVE-2024-57699 see https://github.com/netplex/json-smart-v2/releases/tag/2.5.2 Karate uses `new JsonSmartJsonProvider()` that uses `JSONParser.MODE_PERMISSIVE` that includes `LIMIT_JSON_DEPTH` and therefore is not affected by CVE-2024-57699: https://github.com/karatelabs/karate/blob/v1.5.2.RC2/karate-core/src/main/java/com/intuit/karate/JsonUtils.java#L74 https://github.com/json-path/JsonPath/blob/json-path-2.9.0/json-path/src/main/java/com/jayway/jsonpath/spi/json/JsonSmartJsonProvider.java#L39 https://github.com/netplex/json-smart-v2/blob/2.5.1/json-smart/src/main/java/net/minidev/json/parser/JSONParser.java#L110 However, other projects that use Karate may directly call `new JsonSmartJsonProvider(int parseMode)` with one of the other default modes and are vulnerable. Therefore Karate should ship the fixed version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details about CVE-2024-57699 see
https://github.com/netplex/json-smart-v2/releases/tag/2.5.2
Karate uses
new JsonSmartJsonProvider()that usesJSONParser.MODE_PERMISSIVEthat includesLIMIT_JSON_DEPTHand therefore is not affected by CVE-2024-57699:However, other projects that use Karate may directly call
new JsonSmartJsonProvider(int parseMode)with one of the other default modes and are vulnerable.Therefore Karate should ship the fixed version.
Description
Thanks for contributing this Pull Request. Make sure that you submit this Pull Request against the
developbranch of this repository, add a brief description, and tag the relevant issue(s) and PR(s) below.