Change private/protected to public #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current context there is no way for anyone to make a plugin to change any of the behavior of this module due to there is only few functions that is public. The few that can be changed with a plugin is also very much useless to make a plugin with due the the properties is set to private and therefore unusable within the plugin context.
If you instead tend to try to make a rewrite the classes you will still be facing with issue where all properties is make private as well as most of the functions. Therefor, the only way to properly rewrite any of the classes you need to copy more of less all logic from the class to a local class.
Would help a lot of you just have all functions and properties public.