Toekomstig lidmaatschap #471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rships To make that easier, move the age grouping of relations from the template to the view.
That means they won't get any mail, so to avoid this if it isn't expected mark this in the UI.
aykevl
commented
Jul 26, 2017
| # Only having a special relation means that the user won't get any email | ||
| # which may be unintended, so warn about this situation in the UI. | ||
| rrelated_regular_members = {r['who'] for r in rrelated | ||
| if r['how'] is None and Es.relation_is_active(r)} |
There was a problem hiding this comment.
flake8 klaagt hierover, maar ik weet geen mooie oplossing - hoe zou ik dit beter kunnen opschrijven?
./kn/leden/views.py:135:80: E501 line too long (81 > 79 characters)
bwesterb
reviewed
Jul 28, 2017
| Es.entity_humanName(x['with']), | ||
| Es.entity_humanName(x['how']))) | ||
| rrelated = sorted(e.get_rrelated(), | ||
| key=lambda x: (Es.DT_MIN - Es.relation_until(x), | ||
| key=lambda x: (Es.relation_in_future(x), |
There was a problem hiding this comment.
Waarom hier Es.relation_in_future maar bij related met een not ervoor?
| if r['how'] is None and Es.relation_is_active(r)} | ||
| for r in rrelated: | ||
| if r['who'] not in rrelated_regular_members: | ||
| r['no_regular'] = True |
There was a problem hiding this comment.
Dus dit vlaggetje wordt ook gezet bij relaties in het verleden, waar toen die persoon wel normaal lid geweest heeft kunnen zijn?
|
Het moet wel getest worden. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helaas nog niet alles getest: ik kan
giedoniet werkend krijgen op mijn Vagrant box dus ik kan geen virtuele relaties testen.Maar toekomstig lidmaatschap werkt goed bij mij.