leden: add email settings to smoelenboek #512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a special page with guidance how to add email settings. This is the first step towards moving from using the user password in SMTP towards using a random token, to increase security and to drop the dependency on slapd.
yorickvP
reviewed
Jul 15, 2019
| if not users: | ||
| continue | ||
| ret.map["%s@%s" % (name, settings.MAILDOMAIN)].values.extend(users) | ||
| for member in Es.by_name('leden').get_members(): |
There was a problem hiding this comment.
https://en.wikipedia.org/wiki/G._K._Chesterton#Chesterton's_fence
Het lijkt alsof deze code niet hetzelfde doet. Group membership is namelijk transitief, en deze code lijkt dat niet te zijn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a special page with guidance how to add email settings.
This is the first step towards moving from using the user password in SMTP towards using a random token, to increase security and to drop the dependency on slapd.
Dit verandert vanuit welke adressen leden kunnen verzenden dus ik ga dit nog met het bestuur overleggen.