Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: <carry>: apiextensions-apiserver allow for disabling generation repair #132

Open
wants to merge 1 commit into
base: kcp-feature-logical-clusters-1.24-v3
Choose a base branch
from

Conversation

p0lyn0mial
Copy link

Exposes DisableGenerationRepair option that allows for disabling setting a generation during an object decoding (for objects that haven't had it).
This field is meant to be set by the cache server so that built-in source objects don't differ from the replicated ones.

Previously replicated objects always had the generation field set even if the source/original object hasn't had this field set (i.e. ClusterRoles).

fixes: kcp-dev/kcp#2935

…tion repair

Exposes DisableGenerationRepair option that allows for disabling setting a generation
during an object decoding (for objects that haven't had it).

This field is meant to be set by the cache server so that built-in source objects
don't differ from the replicated ones.
@ncdc
Copy link
Member

ncdc commented Mar 31, 2023

What is the priority on this? Can it wait until after I'm done w/the 1.26 rebase? Or do you need it sooner? @davidfestal

@p0lyn0mial
Copy link
Author

What is the priority on this? Can it wait until after I'm done w/the 1.26 rebase? Or do you need it sooner? @davidfestal

Without this patch the replication controller might be a bit chatty because on each reconciliation some source resources will be always different from the replicated ones (this is true at least for ClusterRoles and ClusterRoleBindings).

Ideally if we could merge it sooner than later. Thanks!

@davidfestal
Copy link
Member

@ncdc if we wait for this PR to be merged before PR kcp-dev/kcp#2933 is merged, as suggested by @p0lyn0mial, that would mean that the whole TMC Sharding support work would be delayed.

@ncdc
Copy link
Member

ncdc commented Apr 3, 2023

Ok, please feel free to merge when you're ready and I'll adjust in the rebase. Thanks for the clarification!

@p0lyn0mial
Copy link
Author

OK, we've decided to merge it after the rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generation number doesn't seem correctly set on cached builtin resources.
3 participants