Merge pull request #188 from keaven/no-ragg

Replace ragg PNG device with native SVG device for vignettes
keaven · Mar 3, 2025 · daea8db · daea8db
2 parents 4afc511 + e5372c8
commit daea8db
Show file tree

Hide file tree

Showing 14 changed files with 27 additions and 35 deletions.
diff --git a/.github/workflows/R-CMD-check.yaml b/.github/workflows/R-CMD-check.yaml
@@ -33,6 +33,10 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      # To support plotting with SVG device under macOS
+      - if: runner.os == 'macOS'
+        run: brew install --cask xquartz
+
       - uses: r-lib/actions/setup-pandoc@v2
 
       - uses: r-lib/actions/setup-r@v2

diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,5 +1,5 @@
 Package: gsDesign
-Version: 3.6.6
+Version: 3.6.7
 Title: Group Sequential Design
 Authors@R: c(
     person("Keaven", "Anderson", email = "[email protected]", role = c("aut", "cre")),
@@ -38,7 +38,6 @@ Suggests:
     kableExtra,
     knitr,
     mvtnorm,
-    ragg,
     rmarkdown,
     scales,
     testthat,

diff --git a/NEWS.md b/NEWS.md
@@ -1,3 +1,14 @@
+# gsDesign 3.6.7 (March 2025)
+
+## Improvements
+
+- All plots in vignettes are now generated by the native SVG device
+  for shaper apperance and fewer package dependencies (@nanxstats, #188).
+
+## Testing
+
+- Add independent unit tests for `toInteger()` (@DMuriuki, #186).
+
 # gsDesign 3.6.6 (February 2025)
 
 ## New features

diff --git a/vignettes/ConditionalErrorSpending.Rmd b/vignettes/ConditionalErrorSpending.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 2,
+  dev = "svg",
   fig.width = 7,
   fig.asp = 1,
   fig.align = "center",

diff --git a/vignettes/ConditionalPowerPlot.Rmd b/vignettes/ConditionalPowerPlot.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/GentleIntroductionToGSD.Rmd b/vignettes/GentleIntroductionToGSD.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = FALSE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/PoissonMixtureModel.Rmd b/vignettes/PoissonMixtureModel.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/SpendingFunctionOverview.Rmd b/vignettes/SpendingFunctionOverview.Rmd
@@ -14,9 +14,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.align = "center",
   out.width = "80%"

diff --git a/vignettes/SurvivalOverview.Rmd b/vignettes/SurvivalOverview.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/VaccineEfficacy.Rmd b/vignettes/VaccineEfficacy.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = FALSE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/binomialSPRTExample.Rmd b/vignettes/binomialSPRTExample.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/gsDesignPackageOverview.Rmd b/vignettes/gsDesignPackageOverview.Rmd
@@ -14,9 +14,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/gsSurvBasicExamples.Rmd b/vignettes/gsSurvBasicExamples.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",

diff --git a/vignettes/nNormal.Rmd b/vignettes/nNormal.Rmd
@@ -12,9 +12,7 @@ vignette: >
 knitr::opts_chunk$set(
   collapse = TRUE,
   comment = "#>",
-  dev = "ragg_png",
-  dpi = 96,
-  fig.retina = 1,
+  dev = "svg",
   fig.width = 7.2916667,
   fig.asp = 0.618,
   fig.align = "center",