Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TxtProperties: new method to get a HashMap of properties #303

Merged
merged 5 commits into from
Feb 9, 2025
Merged

TxtProperties: new method to get a HashMap of properties #303

merged 5 commits into from
Feb 9, 2025

Conversation

keepsimple1
Copy link
Owner

@keepsimple1 keepsimple1 commented Feb 6, 2025 •
edited
Loading

This is to follow up on issue #300 . Added a new method that consumes TxtProperties and returns a simple HashMap.

@keepsimple1 keepsimple1 mentioned this pull request Feb 6, 2025
Closed
Luni-4
Luni-4 reviewed Feb 6, 2025
View reviewed changes
Copy link

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR, very appreciated! :)

Some changes I would make, let me know if they are feasible in your opinion

Luni-4
Luni-4 reviewed Feb 6, 2025
View reviewed changes
Luni-4
Luni-4 suggested changes Feb 7, 2025
View reviewed changes
Copy link

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last changes and it is fine for me

Luni-4
Luni-4 approved these changes Feb 8, 2025
View reviewed changes
Copy link

@Luni-4 Luni-4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me, thank you!

@keepsimple1 keepsimple1 changed the title Draft: TxtProperties: new method to get a HashMap TxtProperties: new method to get a HashMap of properties Feb 9, 2025
@keepsimple1
Copy link
Owner Author

Thank you for your review! I updated the comments to make it clearer and added a test case.

@keepsimple1 keepsimple1 merged commit fba8025 into main Feb 9, 2025
3 checks passed
@keepsimple1 keepsimple1 deleted the property-map branch February 9, 2025 19:42
@Luni-4
Copy link

Luni-4 commented Feb 10, 2025

Cool! Thanks a lot for your update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luni-4 Luni-4 Luni-4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keepsimple1 @Luni-4