Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update the docs home page #2119

Merged
merged 51 commits into from
Jan 31, 2025
Merged

feat: update the docs home page #2119

merged 51 commits into from
Jan 31, 2025

Conversation

elevatebart
Copy link
Contributor

closes #2091

Copy link

cloudflare-workers-and-pages bot commented Jan 22, 2025

Deploying kestra-io with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59d0a3a
Status:⚡️  Build in progress...

View logs

@anna-geller
Copy link
Member

anna-geller commented Jan 23, 2025

@elevatebart two things I noticed:

  • the logo looks a bit off, see below - can you check?
    image

  • the Support section linking Slack/GitHub etc is missing + maybe we can cut the "Was this page helpful" on the homepage?
    image

@Piyush-r-bhaskar
Copy link
Contributor

Hey @elevatebart ,

I was checking the changes from your branch docs-home-page for issue #2074 (It's fixed).
& was getting import error for icons under SupportLinks.vue

It seems Icons imported is case sensitive. & Page rendered with no error with below import:

import GithubIcon from 'vue-material-design-icons/Github.vue';
import SlackIcon from 'vue-material-design-icons/Slack.vue';
import LifebuoyIcon from 'vue-material-design-icons/Lifebuoy.vue';

@elevatebart
Copy link
Contributor Author

Oh thank you @Piyush-r-bhaskar

Just made the change 🤞🏻

@anna-geller anna-geller merged commit fffc49c into main Jan 31, 2025
1 check was pending
@anna-geller anna-geller deleted the docs-home-page branch January 31, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement new Docs homepage
3 participants