Skip to content

Commit

Permalink
fix(amazonq): replace icons with text (aws#6398)
Browse files Browse the repository at this point in the history
## Problem

The multiple icons in the top right of our Transformation Hub were not
easily visible or sufficiently clear to users.

## Solution

Remove the icons, replacing them with a description of what the
icon/button does.

---

- Treat all work as PUBLIC. Private `feature/x` branches will not be
squash-merged at release time.
- Your code changes must meet the guidelines in
[CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines).
- License: I confirm that my contribution is made under the terms of the
Apache 2.0 license.

---------

Co-authored-by: David Hasani <[email protected]>
  • Loading branch information
2 people authored and kevluu-aws committed Jan 23, 2025
1 parent 4a791e4 commit 3345e06
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 23 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
{
"type": "Bug Fix",
"description": "/transform: replace icons in Transformation Hub with text"
}
28 changes: 9 additions & 19 deletions packages/amazonq/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -314,16 +314,14 @@
"group": "navigation@3"
},
{
"command": "aws.amazonq.transformationHub.summary.reveal",
"when": "view == aws.amazonq.transformationHub"
},
{
"command": "aws.amazonq.transformationHub.reviewChanges.reveal",
"when": "view == aws.amazonq.transformationHub"
"command": "aws.amazonq.showTransformationPlanInHub",
"when": "view == aws.amazonq.transformationHub",
"group": "navigation@4"
},
{
"command": "aws.amazonq.showTransformationPlanInHub",
"when": "view == aws.amazonq.transformationHub"
"command": "aws.amazonq.transformationHub.summary.reveal",
"when": "view == aws.amazonq.transformationHub",
"group": "navigation@5"
},
{
"command": "aws.amazonq.transformationHub.reviewChanges.acceptChanges",
Expand Down Expand Up @@ -568,11 +566,6 @@
"title": "%AWS.command.q.transform.showChangeSummary%",
"enablement": "gumby.isSummaryAvailable"
},
{
"command": "aws.amazonq.transformationHub.reviewChanges.reveal",
"title": "%AWS.command.q.transform.showChanges%",
"enablement": "gumby.reviewState == InReview"
},
{
"command": "aws.amazonq.showTransformationPlanInHub",
"title": "%AWS.command.q.transform.showTransformationPlan%",
Expand Down Expand Up @@ -643,19 +636,16 @@
},
{
"command": "aws.amazonq.stopTransformationInHub",
"title": "Stop Transformation",
"icon": "$(stop)",
"title": "%AWS.command.q.transform.stopJobInHub%",
"enablement": "gumby.isStopButtonAvailable"
},
{
"command": "aws.amazonq.showPlanProgressInHub",
"title": "Show Transformation Status",
"icon": "$(checklist)"
"title": "%AWS.command.q.transform.viewJobProgress%"
},
{
"command": "aws.amazonq.showHistoryInHub",
"title": "Show Job Status",
"icon": "$(history)"
"title": "%AWS.command.q.transform.viewJobStatus%"
},
{
"command": "aws.amazonq.selectCustomization",
Expand Down
8 changes: 5 additions & 3 deletions packages/core/package.nls.json
Original file line number Diff line number Diff line change
Expand Up @@ -240,9 +240,11 @@
"AWS.command.codewhisperer.openReferencePanel": "Open Code Reference Log",
"AWS.command.q.transform.acceptChanges": "Accept",
"AWS.command.q.transform.rejectChanges": "Reject",
"AWS.command.q.transform.showChanges": "Show Proposed Changes",
"AWS.command.q.transform.showChangeSummary": "Show Transformation Summary",
"AWS.command.q.transform.showTransformationPlan": "Show Transformation Plan",
"AWS.command.q.transform.stopJobInHub": "Stop job",
"AWS.command.q.transform.viewJobProgress": "View job progress",
"AWS.command.q.transform.viewJobStatus": "View job status",
"AWS.command.q.transform.showTransformationPlan": "View plan",
"AWS.command.q.transform.showChangeSummary": "View summary",
"AWS.command.threatComposer.createNew": "Create New Threat Composer File",
"AWS.command.threatComposer.newFile": "Threat Composer File",
"AWS.threatComposer.page.title": "{0} (Threat Composer)",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export class TransformationHubViewProvider implements vscode.WebviewViewProvider
</style>
</head>
<body>
<p><b>Job Status</b></p>
<p><b>Transformation Status</b></p>
${
Object.keys(sessionJobHistory).length === 0
? `<p>${CodeWhispererConstants.nothingToShowMessage}</p>`
Expand Down

0 comments on commit 3345e06

Please sign in to comment.