-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change method to PATCH for events not organized by yourself #580
base: legacy
Are you sure you want to change the base?
Change method to PATCH for events not organized by yourself #580
Conversation
This avoids 403 forbidden messages when dismissing notifications on events that you are not the organizer for.
15f75e5
to
da5a5d4
Compare
Does this also work for non-primary calendars, i.e. use normal http methods for regular changes on those calendars? They have a slightly different organizer format. |
I'm not sure. It definitely does not fix all problems, at least I still have problems if I have a reminder for an event that's been deleted on the server as I haven't been able to find a way to force a full resync. The existing sync mechanism seems insufficient as you won't get refreshed info for the deleted events, so they remain out of sync. |
Another alternative would be to make the module return false for the ACL check in Thunderbird if we're not the event organiser - if that's possible, of course. Looking at the Thunderbird code, that should skip over any further checks that would throw errors, and just dismiss the item. |
Also fixes #673 Any way we move this forward? 6 months for this critical patch seems to be a lot. What can be done to support this effort? |
Does this have any relation to #224? |
upon quick glance, i doubt it. that seems to be about the general architecture of the extension w.r.t the various available Thunderbird APIs |
patch is just an HTTP method. I don't think this would require any major architectural changes. The part of the code that sends the updated event to google may just be using the wrong method so it could easily be a pretty quick fix for someone who knows the codebase really well and has time. Disclaimer: i dont know the codebase in detail. I also am no longer a gdata provider user since switching to proton calendar |
This avoids 403 forbidden messages when dismissing notifications on events that you are not the organizer for.
Fixes #3