Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method to PATCH for events not organized by yourself #580

Open
wants to merge 1 commit into
base: legacy
Choose a base branch
from

Conversation

eivindt
Copy link

@eivindt eivindt commented Feb 15, 2023

This avoids 403 forbidden messages when dismissing notifications on events that you are not the organizer for.

Fixes #3

@eivindt eivindt changed the title Change method to PATH for events not organized by yourself Change method to PATCH for events not organized by yourself Feb 15, 2023
This avoids 403 forbidden messages when dismissing notifications
on events that you are not the organizer for.
@eivindt eivindt force-pushed the fix/dismiss-notifications-non-organizer branch from 15f75e5 to da5a5d4 Compare February 15, 2023 07:52
@eivindt
Copy link
Author

eivindt commented Feb 15, 2023

This probably also fixes #572 and #554.

@kewisch
Copy link
Owner

kewisch commented Jul 8, 2023

Does this also work for non-primary calendars, i.e. use normal http methods for regular changes on those calendars? They have a slightly different organizer format.

@eivindt
Copy link
Author

eivindt commented Jul 8, 2023

I'm not sure. It definitely does not fix all problems, at least I still have problems if I have a reminder for an event that's been deleted on the server as I haven't been able to find a way to force a full resync.

The existing sync mechanism seems insufficient as you won't get refreshed info for the deleted events, so they remain out of sync.

@Rohaq
Copy link

Rohaq commented Oct 16, 2023

Another alternative would be to make the module return false for the ACL check in Thunderbird if we're not the event organiser - if that's possible, of course. Looking at the Thunderbird code, that should skip over any further checks that would throw errors, and just dismiss the item.

@EugenMayer
Copy link

EugenMayer commented Oct 24, 2023

Also fixes #673

Any way we move this forward? 6 months for this critical patch seems to be a lot. What can be done to support this effort?

@wt
Copy link

wt commented Dec 10, 2024

Does this have any relation to #224?

@MoralCode
Copy link

MoralCode commented Dec 10, 2024

Does this have any relation to #224?

upon quick glance, i doubt it. that seems to be about the general architecture of the extension w.r.t the various available Thunderbird APIs

@wt
Copy link

wt commented Dec 11, 2024

I am asking because #781 also refers to #224 as a path to fix the problem. Apparently, using patch is also the key for that one. I am wondering if #224 is still progressing, and if that architecture change is needed to fix this issue.

@MoralCode
Copy link

patch is just an HTTP method. I don't think this would require any major architectural changes. The part of the code that sends the updated event to google may just be using the wrong method so it could easily be a pretty quick fix for someone who knows the codebase really well and has time.

Disclaimer: i dont know the codebase in detail. I also am no longer a gdata provider user since switching to proton calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

403 forbidden dismissing event notification (Bugzilla Bug 1150571)
7 participants