-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: One-Time Secret Display for API Key (#771) #799
base: develop
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
can you send in a screen recording for this? |
This is very odd. Are you sure your banch is updated? |
@shreyanshVIT23 I think you haven't built the schemas, you need to use the command |
@shreyanshVIT23 any progress? |
Yes thankfully i have made some progress but now i am facing another issue. The error was because the prisma client wasn't generating for some reason so I had to manually set the schema.prisma location and run it. Now i am running the https://github.com/user-attachments/assets/5ab4632e-3180-4bfb-99e4-8023d3b7617a |
@shreyanshVIT23 did you run the API? this error means that it couldn't reach the backend. Also make sure you have set |
@shreyanshVIT23 any updates? |
Yes! I am finally able to run the frontend thankfully. Keyshade docs with running locally section where huge help. I had to set up sentry account and SMTP which i didn't know about at all but the error messages where extremely helpful and https://www.youtube.com/watch?v=FFPHHXOlJC4&t=2236s where a huge help. But I am unable to see any option to create api key is that something I must implement? |
Update your fork with the latest code. It has the changes |
User description
Description
Implemented the One-Time Secret Display for API Keys.
Fixes #771
Dependencies
shadcn/ui
components for UI consistency.lucide-react
icons for UI elements.Future Improvements
Mentions
@keyshade-xyz/team @maintainers
PR Type
Enhancement
Description
Added a new
OneTimeSecretDisplay
component to show API keys once.Implemented UI elements for copying and toggling API key visibility.
Included warning message emphasizing one-time visibility of API keys.
Integrated dialog functionality with customizable open/close behavior.
Changes walkthrough 📝
index.tsx
Add `OneTimeSecretDisplay` component for API key
apps/platform/src/components/dashboard/secret/OneTimeSecretDisplay/index.tsx
OneTimeSecretDisplay
component for API key display.