-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(member): 생일자 조회 에러 수정, 도서 추가 및 삭제/검색 기능 구현 #266
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #266 +/- ##
==========================================
- Coverage 94.06% 93.66% -0.40%
==========================================
Files 14 14
Lines 219 221 +2
Branches 37 39 +2
==========================================
+ Hits 206 207 +1
- Misses 11 12 +1
Partials 2 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
구현하시느라 고생 많으셨어요! Form 데이터 처리 관련해서 의견 남겨두었어요. 전반적으로 그 외에는 깔끔하게 작성된 것 같아 approve 해 두겠습니다. 수고하셨어요 😁
const { open } = useMemberInfoModal(); | ||
const { page, size, handlePageChange } = usePagination({ | ||
sectionName: 'library', | ||
}); | ||
const [inputs, setInputs] = useState<Book>({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 부분은 Form을 통해 받아온 데이터를 관리하는 것 같은데, useReducer 나 react-hook-form을 이용해 보시는 것은 어떨까요? 초기 데이터와 값을 받아 변경시키는 과정을 더욱 체계적으로 관리할 수 있을 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
react-hook-form
을 사용해서 리팩토링했어요. 추후에 members 내에 존재하는 모든 form
을 react-hook-form
을 사용하도록 리팩토링 할게요 :)
Summary
Tasks
Screenshot