Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(member): 생일자 조회 에러 수정, 도서 추가 및 삭제/검색 기능 구현 #266

Merged
merged 9 commits into from
Feb 9, 2025

Conversation

Jeong-Ag
Copy link
Member

@Jeong-Ag Jeong-Ag commented Feb 5, 2025

Summary

#265

  • 생일자 조회 시 제한된 size로 생일자가 전부 나타나지 않던 문제를 해결했어요.
  • 도서 등록과 삭제, 검색을 할 수 있도록 기능을 추가했어요.

Tasks

  • 생일자 조회 API size를 99로 변경
  • 관리페이지의 도서 탭에서 도서 등록, 삭제를 위한 탭 추가
  • 도서 페이지 내에서 검색 기능 추가

Screenshot

스크린샷 2025-02-05 오후 6 16 31 스크린샷 2025-02-05 오후 6 16 39 스크린샷 2025-02-05 오후 6 16 16

@Jeong-Ag Jeong-Ag added ✨ Feature 새로운 기능 명세 및 개발 🔨 Refactor 코드 수정 및 최적화 🏠 Member member 프로젝트 관련 labels Feb 5, 2025
@Jeong-Ag Jeong-Ag self-assigned this Feb 5, 2025
Copy link

changeset-bot bot commented Feb 5, 2025

⚠️ No Changeset found

Latest commit: 1b0f517

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.66%. Comparing base (0c66f87) to head (1b0f517).
Report is 115 commits behind head on main.

@@            Coverage Diff             @@
##             main     #266      +/-   ##
==========================================
- Coverage   94.06%   93.66%   -0.40%     
==========================================
  Files          14       14              
  Lines         219      221       +2     
  Branches       37       39       +2     
==========================================
+ Hits          206      207       +1     
- Misses         11       12       +1     
  Partials        2        2              

see 2 files with indirect coverage changes

Copy link
Contributor

@yummjin yummjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구현하시느라 고생 많으셨어요! Form 데이터 처리 관련해서 의견 남겨두었어요. 전반적으로 그 외에는 깔끔하게 작성된 것 같아 approve 해 두겠습니다. 수고하셨어요 😁

const { open } = useMemberInfoModal();
const { page, size, handlePageChange } = usePagination({
sectionName: 'library',
});
const [inputs, setInputs] = useState<Book>({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요 부분은 Form을 통해 받아온 데이터를 관리하는 것 같은데, useReducerreact-hook-form을 이용해 보시는 것은 어떨까요? 초기 데이터와 값을 받아 변경시키는 과정을 더욱 체계적으로 관리할 수 있을 것 같아요

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-hook-form을 사용해서 리팩토링했어요. 추후에 members 내에 존재하는 모든 formreact-hook-form을 사용하도록 리팩토링 할게요 :)

@Jeong-Ag Jeong-Ag merged commit c44f441 into main Feb 9, 2025
5 checks passed
@Jeong-Ag Jeong-Ag deleted the feature/265 branch February 9, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature 새로운 기능 명세 및 개발 🏠 Member member 프로젝트 관련 🔨 Refactor 코드 수정 및 최적화
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants