Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Properly decode file content before validation #750

Merged
merged 3 commits into from
Sep 21, 2021

Conversation

znatty22
Copy link
Member

Workaround for #749

@znatty22 znatty22 force-pushed the fix-validation-input branch 2 times, most recently from 0a6b50c to 7f7d2e6 Compare September 21, 2021 15:35
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #750 (d688aa7) into master (d7e59b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #750   +/-   ##
=======================================
  Coverage   94.85%   94.86%           
=======================================
  Files         171      171           
  Lines        7441     7453   +12     
=======================================
+ Hits         7058     7070   +12     
  Misses        383      383           
Impacted Files Coverage Δ
creator/files/models.py 97.79% <100.00%> (+0.12%) ⬆️
creator/ingest_runs/tasks/validation_run.py 98.89% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e59b7...d688aa7. Read the comment docs.

@znatty22 znatty22 force-pushed the fix-validation-input branch 3 times, most recently from 42e2760 to 57f81f5 Compare September 21, 2021 17:06
@znatty22 znatty22 changed the title 🐛 Use read_df to properly decode file content before validation 🐛 Properly decode file content before validation Sep 21, 2021
@znatty22 znatty22 force-pushed the fix-validation-input branch from 57f81f5 to f8c783f Compare September 21, 2021 17:19
@znatty22 znatty22 marked this pull request as ready for review September 21, 2021 17:34
@gsantia
Copy link
Contributor

gsantia commented Sep 21, 2021

codecov patch check is failing, does that matter?

@znatty22 znatty22 force-pushed the fix-validation-input branch from f8c783f to e797adb Compare September 21, 2021 18:15
Copy link
Contributor

@gsantia gsantia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧶

@znatty22 znatty22 force-pushed the fix-validation-input branch from e797adb to d688aa7 Compare September 21, 2021 20:38
@znatty22 znatty22 merged commit 77f1f42 into master Sep 21, 2021
@znatty22 znatty22 deleted the fix-validation-input branch September 21, 2021 20:46
znatty22 added a commit that referenced this pull request Sep 22, 2021
## Release 1.19.6

### Summary

- Emojis: ♻️ x1, 🐛 x1
- Categories: Fixes x1, Other Changes x1

### New features and changes

- [#741](#741) - ♻️ Restore old general file types and add new ones - [c3a6ecd](c3a6ecd) by [znatty22](https://github.com/znatty22)
- [#750](#750) - 🐛 Properly decode file content before validation - [77f1f42](77f1f42) by [znatty22](https://github.com/znatty22)
@znatty22 znatty22 mentioned this pull request Sep 22, 2021
znatty22 added a commit that referenced this pull request Sep 27, 2021
## Release 1.19.6

### Summary

- Emojis: ♻️ x2, 🐛 x1
- Categories: Fixes x1, Other Changes x2

### New features and changes

- [#753](#753) - ♻️ Adjust validation rules and report - [cdabec7](cdabec7) by [znatty22](https://github.com/znatty22)
- [#741](#741) - ♻️ Restore old general file types and add new ones - [c3a6ecd](c3a6ecd) by [znatty22](https://github.com/znatty22)
- [#750](#750) - 🐛 Properly decode file content before validation - [77f1f42](77f1f42) by [znatty22](https://github.com/znatty22)
znatty22 added a commit that referenced this pull request Sep 27, 2021
## Release 1.19.6

### Summary

- Emojis: 🔊 x1, ♻️ x2, 🐛 x1
- Categories: Additions x1, Fixes x1, Other Changes x2

### New features and changes

- [#761](#761) - 🔊 Configure release task logging directly - [7ecbb63](7ecbb63) by [znatty22](https://github.com/znatty22)
- [#753](#753) - ♻️ Adjust validation rules and report - [cdabec7](cdabec7) by [znatty22](https://github.com/znatty22)
- [#741](#741) - ♻️ Restore old general file types and add new ones - [c3a6ecd](c3a6ecd) by [znatty22](https://github.com/znatty22)
- [#750](#750) - 🐛 Properly decode file content before validation - [77f1f42](77f1f42) by [znatty22](https://github.com/znatty22)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants