Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Push expected file uploads to Dewrangle #801

Closed
wants to merge 17 commits into from

Conversation

znatty22
Copy link
Member

@znatty22 znatty22 commented Dec 6, 2021

Closes #800. Note that handling of failures will be implemented in a subsequent PR (#814)

image

@znatty22 znatty22 added the feature New functionality label Dec 6, 2021
@znatty22 znatty22 self-assigned this Dec 6, 2021
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch 2 times, most recently from de59c44 to 5a877cc Compare December 7, 2021 00:44
@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #801 (ae0a453) into dewrangle-study-org (966c4ff) will increase coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           dewrangle-study-org     #801      +/-   ##
=======================================================
+ Coverage                95.77%   95.90%   +0.13%     
=======================================================
  Files                      174      180       +6     
  Lines                     7591     7834     +243     
=======================================================
+ Hits                      7270     7513     +243     
  Misses                     321      321              
Impacted Files Coverage Δ
creator/dewrangle/client.py 100.00% <100.00%> (ø)
creator/dewrangle/graphql.py 100.00% <100.00%> (ø)
creator/files/models.py 97.90% <100.00%> (+0.31%) ⬆️
creator/files/mutations/file.py 99.23% <100.00%> (+0.03%) ⬆️
creator/files/mutations/version.py 94.92% <100.00%> (+0.03%) ⬆️
creator/files/utils.py 100.00% <100.00%> (ø)
creator/storage_analyses/__init__.py 100.00% <100.00%> (ø)
creator/storage_analyses/apps.py 100.00% <100.00%> (ø)
creator/storage_analyses/factories.py 100.00% <100.00%> (ø)
creator/storage_analyses/models.py 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 966c4ff...ae0a453. Read the comment docs.

@znatty22 znatty22 force-pushed the push-file-upload-manifest branch 9 times, most recently from 5eb0e62 to 83ac33f Compare December 13, 2021 15:30
@znatty22 znatty22 changed the base branch from master to dewrangle-study-org December 13, 2021 15:31
@znatty22
Copy link
Member Author

After discussion with @shanewilson

  • Possibly rethink if we want to create study/org that doesn't exist in Dewrangle. Gotta think about sync of entities between two systems (what if someone deletes a study in Dewrangle that Data Tracker knows about, etc)

@znatty22 znatty22 force-pushed the push-file-upload-manifest branch from 83ac33f to 16dc71d Compare December 14, 2021 23:30
@znatty22 znatty22 force-pushed the dewrangle-study-org branch 3 times, most recently from 516268e to e1a0654 Compare December 17, 2021 01:01
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch from 16dc71d to 4aaaa21 Compare December 20, 2021 02:17
@znatty22 znatty22 force-pushed the dewrangle-study-org branch from 340f98c to 933d821 Compare December 20, 2021 03:00
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch from 4aaaa21 to bb46de3 Compare December 21, 2021 17:43
@znatty22 znatty22 changed the title ✨ Push file upload invoices to Dewrangle ✨ Push expected file uploads to Dewrangle Jan 12, 2022
@znatty22 znatty22 force-pushed the dewrangle-study-org branch 3 times, most recently from 18ecb3b to c7a2e6d Compare January 27, 2022 16:27
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch 3 times, most recently from 2090054 to 089b750 Compare January 27, 2022 18:02
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch 2 times, most recently from c0ac8a5 to c3641b6 Compare January 31, 2022 19:54
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch 10 times, most recently from 38be728 to 52250f0 Compare February 4, 2022 16:48
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch from f3693f1 to 139b6a4 Compare February 4, 2022 19:53
@znatty22 znatty22 force-pushed the push-file-upload-manifest branch from 139b6a4 to ae0a453 Compare February 5, 2022 00:25
@znatty22 znatty22 closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push file upload manifests to Dewrangle
1 participant