Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 genotyping release prep #64

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Conversation

dmiller15
Copy link
Collaborator

@dmiller15 dmiller15 commented Jan 21, 2025

Description

Changes in this update:

  • Update the output filenames for the genotyping workflow to be more uniform and informative
  • Put more explicit documentation into the GATK_GERMLINE doc explaining how filtering differs between WGS and WXS/Targeted
  • Add defaults for new parameter
  • Adjusted requirements for some inputs to be in line with the CYOA-nature of the workflow
  • Bump minor version for release

Closes https://d3b.atlassian.net/browse/BIXU-3800

Type of change

  • New feature (non-breaking change which adds functionality)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test Configuration:

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@dmiller15 dmiller15 added documentation Regarding developer or user documentation feature New functionality bix-dev This issue or pull request is bix-dev work labels Jan 21, 2025
@dmiller15 dmiller15 self-assigned this Jan 21, 2025
@dmiller15 dmiller15 marked this pull request as ready for review January 22, 2025 14:59
@dmiller15 dmiller15 added the bug Something isn't working label Jan 22, 2025
Copy link
Member

@migbro migbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a minor comment

@dmiller15 dmiller15 merged commit db0126e into master Jan 23, 2025
1 check passed
@dmiller15 dmiller15 deleted the dm-genotyping-release-prep branch January 23, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev This issue or pull request is bix-dev work bug Something isn't working documentation Regarding developer or user documentation feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants