Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for animation before tapping #1311

Closed

Conversation

chenj-hub
Copy link

@chenj-hub chenj-hub commented Nov 7, 2024

What changed?

Small change, wait for animation to complete before attempting to tap.

Why?

When the view.window.firstResponder != view, it can take a bit time for the view to be tappable. Moving the wait to before attempting to tap it. Without this change, we hit an error when attempting to enter text.

How is it tested?

Pointed our local breaking tests to this change, and it worked 100 times. Also ran the ci.sh script against a device, and nothing failed.

Demo

./KIF/Scripts/ci.sh "name=iPhone 14,OS=16.2"

         Executed 4 tests, with 0 failures (0 unexpected) in 6.431 (7.754) seconds

2024-11-07 16:15:27.179 xcodebuild[2989:1855051] [MT] IDETestOperationsObserverDebug: 13.657 elapsed -- Testing started completed.
2024-11-07 16:15:27.179 xcodebuild[2989:1855051] [MT] IDETestOperationsObserverDebug: 0.000 sec, +0.000 sec -- start
2024-11-07 16:15:27.179 xcodebuild[2989:1855051] [MT] IDETestOperationsObserverDebug: 13.657 sec, +13.657 sec -- end
▸ Test Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant