Wait for animation before tapping #1311
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Small change, wait for animation to complete before attempting to tap.
Why?
When the
view.window.firstResponder != view
, it can take a bit time for the view to be tappable. Moving the wait to before attempting to tap it. Without this change, we hit an error when attempting to enter text.How is it tested?
Pointed our local breaking tests to this change, and it worked 100 times. Also ran the
ci.sh
script against a device, and nothing failed.Demo