github action mingw cross #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
current problem: mingw doesn't have a regex library. squid-cache#1232 should fix this |
test-builds.sh records build output in per-layer logs, and we are already collecting those logs. Send build output to standard output as well, to expose it in GitHub Actions user interface. This new detailed output is enclosed in a "layer ... output" group to keep emphasizing problematic output lines extracted by test-builds.sh. Also enclose MacOS build setup output in a group, for similar reasons.
During shutdown, iocb_table global was deleted, but the corresponding cleanup code ignored some IoCallback members, triggering misleading Ipc::UdsSender memory leak reports from Valgrind. This change uses NoNewGlobals design to address the above problem, but this code needs a lot more refactoring to address other old problems associated with Comm initialization.
store/Disks.cc:690: error: argument 1 value 18446744073709551615
exceeds maximum object size 9223372036854775807
[-Werror=alloc-size-larger-than=]
const auto tmp = new SwapDir::Pointer[swap->n_allocated];
pconn.cc:43:53: error: argument 1 value 18446744073709551615 ...
theList_ = new Comm::ConnectionPointer[capacity_];
Tested on Ubuntu 24.04 and GCC v13.2.0.
…he#2000) GitHub Actions UI does not handle large amounts of console output with collapsable `::group::` sections well. For example, UI may truncate console output if a collapsable `::group::` section gets too many log lines. In some cases, GitHub does not report truncation at all, resulting in misleading console output. In other, UI warns: "This step has been truncated due to its large size. Download the full logs from the menu once the workflow run has completed." This change reverts recent commit e5a66fc.
kinkie
force-pushed
the
github-action-mingw-cross
branch
from
1d02828 to
9961a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - use a github action to test Squid on a Mingw target.
Also use it as a chance to get mingw to build altogether