-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Proximity Sensor #362
Open
sumitmadhwani
wants to merge
7
commits into
kivy:master
Choose a base branch
from
sumitmadhwani:proximity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
iOS Proximity Sensor #362
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
7c3607c
Add iOS api for proximity
sumitmadhwani f42fd69
Update README
sumitmadhwani 2e05277
Replace boolean with string
sumitmadhwani 70b2338
Return string instead of boolean
sumitmadhwani 6e4e51f
Merge branch 'master' into proximity
sumitmadhwani ae30e8e
Remove duplicates and arrange in alphabetical order
sumitmadhwani 4ec9231
Update proximity.py
sumitmadhwani File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
''' | ||
iOS Proximity | ||
------------- | ||
''' | ||
|
||
from pyobjus import autoclass | ||
from pyobjus.dylib_manager import load_framework | ||
from plyer.facades import Proximity | ||
|
||
load_framework('/System/Library/Frameworks/UIKit.framework') | ||
UIDevice = autoclass('UIDevice') | ||
|
||
|
||
class iOSProximity(Proximity): | ||
|
||
def __init__(self): | ||
super(iOSProximity, self).__init__() | ||
self.device = UIDevice.currentDevice() | ||
|
||
def _enable(self): | ||
self.device.setProximityMonitoringEnabled_(True) | ||
|
||
def _disable(self): | ||
self.device.setProximityMonitoringEnabled_(False) | ||
|
||
def _get_proximity(self): | ||
if self.device.proximityMonitoringEnabled: | ||
if self.device.proximityState: | ||
return str(True) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why now returning a string of a boolean, both platforms are coded to return a boolean value anyway? |
||
else: | ||
return str(False) | ||
else: | ||
return 'Proximity Sensor in present in your device.' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "is not present" ? |
||
|
||
|
||
def instance(): | ||
return iOSProximity() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tshirtman I was trying to remove this condition statement from here. That's why String Property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's a good idea to change the api to simplify a particular example, especially since a lot of other usages would change from:
to
which is really un-pythonic, the api is better when a boolean value is represented as a boolean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, you could just change the example to this, to achieve the same effect as your previous solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"text: str(root.is_near)"
👍