linux/storagepath: fixup a host of issues #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is the right name according to the XDG spec, and the key used in the default paths dict
- dont assume that ~/.config/user-dirs.dirs exists - don't assume it does have contents or the relevant value - don't use exception handling as happy path control flow - when defaulting, use the path under HOME, not e.g. /Pictures
|
@rski 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issues fixed are explained in the commits:
Author: Romanos Skiadas [email protected]
Date: Fri Sep 17 20:41:42 2021 +0300
commit 99dabb2
Author: Romanos Skiadas [email protected]
Date: Fri Sep 17 20:31:08 2021 +0300
This is a superset of #539. It both fixes more issues, and makes the code a bit simpler, as it removes the exception handling that is not really needed. The reaason for this PR is that the other PR seems to have stalled, and we would like to merge these fixes in order to package plyer for nixpkgs, as it's a dependency of a new version of mirage, which is already packaged.