Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to disable the animation in scrollToIndex when gestureRele… #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gvlekke
Copy link
Contributor

@gvlekke gvlekke commented Jun 14, 2018

What did you do:

I noticed that the slider feels a little bit slow when the gestureRelease triggers.
It was because of the animation in the scrollToIndex. So I added a option to disable that if you dont want the animation.

Maybe a good idea?

Dont know if it is a good idea to have this as a default behaviour? Then the carousel is fast for everyone.

Does this relate to any issue(s)? If so which one(s)?

nope

Checklist:

  • I added link to related issue if there is one
  • I added a screenshot/gif (if appropriate)
  • I ran yarn lint and yarn flow

still in yarn flow things break and dont know how to fix that? can you explain that?

@msevestre
Copy link

@gvlekke Well done. I was trying to find a warkaround for that very issue

@gvlekke
Copy link
Contributor Author

gvlekke commented Jun 15, 2018

@msevestre did you test it yourself already? In my case the experience approved a lot. What is your experience?

@kkemple
Copy link
Owner

kkemple commented Jun 15, 2018

I would love to test this out as well! I'll check it out this weekend!

@msevestre
Copy link

@gvlekke Haven't tried it yet but will hopefully by the end of today or tomorrow

@msevestre
Copy link

@gvlekke I just tried it on a couple devices. Felt much better on an older device and maybe slightly faster on brand new Pixel. I'd say it does not hurt to have the option :)

@msevestre
Copy link

@gvlekke I should add that with the animation turned off, the behavior on my ios simulator does not look as good (e.g. transition from one slide to the other is way too fast). But looks better on devices...

@gvlekke
Copy link
Contributor Author

gvlekke commented Jun 22, 2018

@msevestre yeah that is also what i noticed. Btw we are using now a self made slider that is way faster. It just uses a flatlist. Only problem is that we have some white space when you go from the first item to the last item... When I have time im also going to check if can make some library of that. Then we can compare our stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants