-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump rust to 1.80 and rm lazy_static #1315
Conversation
One question to approve this PR, are there any repos in the ecosystem that have bumped to rust 1.80? Will it break something? Have these repos also replaced lazy_static by LazyLock? |
Yes reth here: paradigmxyz/reth#9799 |
It doesn't seem like reth had lazy_static! to begin with? |
They had But it is continuous improvement also done to remove an additional dependency. If ever we can wait for Greg to have a third opinion on the question :) |
Last question, we've had issues with bumping rust version in the past, is this fine wrt our dependencies? |
Should be fine and as reth will bump, as always if we want to continue using reth we have to bump too... but we could put this pr on hold until we need to bump reth for ex to be 100% sure we absolutely need it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Continuous improvement doesn't wait. 👑 |
Related:
LazyCell
andLazyLock
are stable https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html#lazycell-and-lazylock, giving us the opportunity to remove an useless dependency (static_lazy
).once_cell
withstd::sync
paradigmxyz/reth#9799lazy_static
appears to be intended to be deprecated Officially deprecate lazy_static rust-lang-nursery/lazy-static.rs#214