Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump rust to 1.80 and rm lazy_static #1315

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Conversation

tcoratger
Copy link
Collaborator

Related:

@Eikix
Copy link
Member

Eikix commented Jul 30, 2024

One question to approve this PR, are there any repos in the ecosystem that have bumped to rust 1.80? Will it break something?

Have these repos also replaced lazy_static by LazyLock?

@tcoratger
Copy link
Collaborator Author

One question to approve this PR, are there any repos in the ecosystem that have bumped to rust 1.80? Will it break something?

Have these repos also replaced lazy_static by LazyLock?

Yes reth here: paradigmxyz/reth#9799

@Eikix
Copy link
Member

Eikix commented Jul 30, 2024

One question to approve this PR, are there any repos in the ecosystem that have bumped to rust 1.80? Will it break something?
Have these repos also replaced lazy_static by LazyLock?

Yes reth here: paradigmxyz/reth#9799

It doesn't seem like reth had lazy_static! to begin with?

@tcoratger
Copy link
Collaborator Author

?

They had once_cell::sync::Lazy which is equivalent but not a macro. Also I read this issue rust-lang-nursery/lazy-static.rs#214 which seems to favor a deprecation of lazy_static and now that the equivalent feature is stable on std, I fear that this deprecation will accelerate so I wanted to move forward before.

But it is continuous improvement also done to remove an additional dependency. If ever we can wait for Greg to have a third opinion on the question :)

@Eikix
Copy link
Member

Eikix commented Jul 31, 2024

?

They had once_cell::sync::Lazy which is equivalent but not a macro. Also I read this issue rust-lang-nursery/lazy-static.rs#214 which seems to favor a deprecation of lazy_static and now that the equivalent feature is stable on std, I fear that this deprecation will accelerate so I wanted to move forward before.

But it is continuous improvement also done to remove an additional dependency. If ever we can wait for Greg to have a third opinion on the question :)

Last question, we've had issues with bumping rust version in the past, is this fine wrt our dependencies?

@tcoratger
Copy link
Collaborator Author

?

They had once_cell::sync::Lazy which is equivalent but not a macro. Also I read this issue rust-lang-nursery/lazy-static.rs#214 which seems to favor a deprecation of lazy_static and now that the equivalent feature is stable on std, I fear that this deprecation will accelerate so I wanted to move forward before.
But it is continuous improvement also done to remove an additional dependency. If ever we can wait for Greg to have a third opinion on the question :)

Last question, we've had issues with bumping rust version in the past, is this fine wrt our dependencies?

Should be fine and as reth will bump, as always if we want to continue using reth we have to bump too... but we could put this pr on hold until we need to bump reth for ex to be 100% sure we absolutely need it.

Copy link
Member

@Eikix Eikix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Eikix
Copy link
Member

Eikix commented Jul 31, 2024

Continuous improvement doesn't wait. 👑

@tcoratger tcoratger added this pull request to the merge queue Jul 31, 2024
Merged via the queue into kkrt-labs:main with commit f70b215 Jul 31, 2024
8 checks passed
@tcoratger tcoratger deleted the rust-1.80 branch July 31, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants