feat: use the middleware instead of injecting a cache #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach has some problems, so I won't take this approach. But I created a PR to put my works.
SWR's middleware allows us to a hook for
useSWR
hooks, which seems to be a good place for SWRDevtools.But this has the following problems.
useSWR
are monitored byswr
to optimize re-rendering, which is implemented by getters. So if we get the data for SWRDevtools, it is marked as "used" and causes extra re-rendering. refs feat: record SWR data with useDebugValue #37 (comment).key
strings in middlewares. We can useunstable_serialize
, but how should I handleuseSWRInfinite
?