Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#138 Resize while preserving aspect ratio to specified dimensions, using fill if necessary #144

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

slayful
Copy link

@slayful slayful commented Oct 2, 2019

This should solve #138

@marcing
Copy link

marcing commented Oct 2, 2019

Great. Thank you!

@aszmyd
Copy link

aszmyd commented Jan 15, 2020

This is amazing and very desirable improvement! Please fix the travis build issue so that contributors can merge it after review 👍

@adpaste
Copy link

adpaste commented Nov 21, 2023

@kohler Could you kindly take a look at our PR? Please let us know if any improvements are needed before merging. If it doesn't fit the project, please inform us, and we'll close the PR.

Thank you!

@kohler
Copy link
Owner

kohler commented Feb 19, 2024

Hi, some version of this commit would be good to merge. However, Gifsicle already has multiple color-distance algorithms, including one used by @kornelski’s --lossy option, and the kcolor subsystem used by quantize.c. It seems weird to add another, especially since I’d love to rewrite the existing quantize.c subsystem to optionally use the Oklab color space.

@kohler
Copy link
Owner

kohler commented Feb 19, 2024

So if you could change this commit to use the kcolor framework that would be great.

@adpaste
Copy link

adpaste commented Feb 20, 2024

Thanks for your response! Sure, we added this to our backlog and we will work on that soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants