ENH: add sum() up to 3D #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerjereddy
added a commit
to tylerjereddy/pykokkos
that referenced
this pull request
Jul 19, 2022
* add 1D-3D support for the `prod()` reduction ufunc; largely copies the similar infrastructure for `sum()` from kokkosgh-52 and has the same caveats I think
* add 1D-3D support for the `sum()` reduction ufunc; this is likely the first example of a reduction ufunc I've added so far * most comments/questions are in the source
tylerjereddy
force-pushed
the
treddy_sum_ufunc
branch
from
f93360b to
0aa4ed6
Compare
|
@NaderAlAwar I think I've dealt with the merge conflicts here and CI is passing, so maybe this is the next one to do code review for. |
|
formally, I don't think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sum()reduction ufunc;this is likely the first example of a reduction ufunc
I've added so far
* satisfying the(done in a previously-merged PR now)mypytype hint analysis caused sometests to fail, so I'm suppressing the type hint checks
for the
ufuncsmodule for now