Skip to content

Commit

Permalink
cleanup and add comment
Browse files Browse the repository at this point in the history
  • Loading branch information
zackattack01 committed Dec 19, 2024
1 parent b9e1918 commit 2d74749
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions pkg/osquery/runtime/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,8 @@ func (r *Runner) InstanceStatuses() map[string]types.InstanceStatus {
return instanceStatuses
}

// UpdateRegistrationIDs detects any changes between the new and stored registration IDs,
// and resets the runner instances for the new registrationIDs if required
func (r *Runner) UpdateRegistrationIDs(newRegistrationIDs []string) error {
slices.Sort(newRegistrationIDs)
existingRegistrationIDs := r.registrationIds
Expand Down
2 changes: 1 addition & 1 deletion pkg/osquery/runtime/runtime_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,7 @@ func TestMultipleInstancesWithUpdatedRegistrationIDs(t *testing.T) {

waitShutdown(t, runner, logBytes)

// Confirm both instances exited
// Confirm instance exited
require.Contains(t, runner.instances, types.DefaultRegistrationID)
require.NotNil(t, runner.instances[types.DefaultRegistrationID].stats)
require.NotEmpty(t, runner.instances[types.DefaultRegistrationID].stats.ExitTime, "exit time should be added to default instance stats on shutdown")
Expand Down

0 comments on commit 2d74749

Please sign in to comment.