Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add port-sniffer task #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add port-sniffer task #1

wants to merge 5 commits into from

Conversation

AQuaZar
Copy link

@AQuaZar AQuaZar commented Oct 7, 2019

Looking forward for your feedback 🙂

denysxftr
denysxftr requested changes Oct 7, 2019
View reviewed changes
Copy link
Collaborator

@denysxftr denysxftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done but:

  • apply black tool for autoformatting
  • you can use string interpolation f"blabla {a}" instead of format

submissions/AQuaZar/port-sniffer/sniffer.py Outdated Show resolved Hide resolved
submissions/AQuaZar/port-sniffer/sniffer.py Outdated Show resolved Hide resolved
submissions/AQuaZar/port-sniffer/sniffer.py Show resolved Hide resolved
submissions/AQuaZar/port-sniffer/sniffer.py Outdated Show resolved Hide resolved
denysxftr
denysxftr approved these changes Oct 14, 2019
View reviewed changes
Copy link
Collaborator

@denysxftr denysxftr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@AMashoshyna AMashoshyna added the port-sniffer Port sniffer task label Oct 15, 2019
rekusha
rekusha approved these changes Dec 16, 2019
View reviewed changes
Copy link

@rekusha rekusha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing passed. readable. it seems to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denysxftr denysxftr denysxftr approved these changes

@rekusha rekusha rekusha approved these changes

Assignees
No one assigned
Labels
port-sniffer Port sniffer task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AQuaZar @denysxftr @rekusha @AMashoshyna