fix: don't modify the passed options object (hoodiehq#559)

kouryuu · Aug 30, 2016 · 7a98915 · 7a98915
1 parent 40001d1
commit 7a98915
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/server/index.js b/server/index.js
@@ -10,10 +10,12 @@ var corsHeaders = require('hapi-cors-headers')
 var hoodieServer = require('@hoodie/server').register
 var log = require('npmlog')
 var PouchDB = require('pouchdb-core')
+var cloneDeep = require('lodash').cloneDeep
 
 var registerPlugins = require('./plugins')
 
 function register (server, options, next) {
+  options = cloneDeep(options)
   if (!options.db) {
     options.db = {}
   }

diff --git a/test/integration/server-test.js b/test/integration/server-test.js
@@ -32,6 +32,19 @@ test('server with options.db.url lacking auth', function (t) {
   })
 })
 
+test('does not modify the passed options object', function (t) {
+  var options = {
+    db: {
+      url: 'http://admin:admin@localhost:5984'
+    }
+  }
+
+  hapiPlugin.register(serverMock, options, function () {})
+
+  t.is(options.db.url, 'http://admin:admin@localhost:5984')
+  t.end()
+})
+
 test('server with empty options (#554)', function (t) {
   hapiPlugin.register(serverMock, {}, function (error, config) {
     t.error(error)