Gravity sensor and fix for orientation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuluum
reviewed
Oct 18, 2017
| @@ -105,11 +105,15 @@ public void onSensorChanged(SensorEvent sensorEvent) { | |||
| roll = 360 - (0 - roll); | |||
| } | |||
|
|
|||
| i++; | |||
There was a problem hiding this comment.
I think it's better to move that right under long curTime = System.currentTimeMillis();. Not to make excess work with geting orientation and performing data to send event.
Kuluum
reviewed
Oct 18, 2017
| @@ -10,8 +10,8 @@ | |||
| import android.util.Log; | |||
|
|
|||
| public class SensorManagerModule extends ReactContextBaseJavaModule { | |||
| private static final String REACT_CLASS = "SensorManager"; | |||
| private AccelerometerRecord mAccelerometerRecord = null; | |||
| private static final String REACT_CLASS = "SensorManager"; | |||
There was a problem hiding this comment.
Not the best idea to break the code alignment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added gravity sensor and fixed delay for orientation sensor
#33