GTMv4 and TrackCustomEvent #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargash
commented
Aug 27, 2015
vargash
commented
- A "trackGenericEvent" method has been implemented to enable a more generic event tracking. This currently accept only a single label-value pair of parameters, but will be updated in the future for an even more generic use.
- iOS SDK Libraries have been updated to latest versions.
- Android SDK Libraries and code have been updated from old GTMv3 to newest GTMv4.
|
Hey @vargash, thanks for submitting this PR. Can you make a case for using the GTM v4 library? I'm trying to avoid requiring Google Play Services as a dependency. |
|
I change this code to GTM v4 same day(27 Aug). |
luizcva
pushed a commit
to luizcva/cordova-plugin-tag-manager
that referenced
this pull request
Nov 2, 2015
…pelo autor do plugin, porem esse PR parece ser uma atualizacao importante para a versao mais recente do SDK Android do Google Tag Manager
Close the older container to prevent issues when changing the GTM id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.