simple testing suite for async #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelmdresser @nickcurie @nealormsbee @AjayTripathy , please let me know If you have any comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just added some basic unit tests for the pkg/async package. Nothing fancy, but it's a start for this untested code. The tests cover AtomicBool, WaitChannel, and ConcurrentStringSet, making sure they handle the basics correctly.
I noticed while working on this that testing is pretty sparse throughout the codebase. I'm thinking about expanding coverage to other critical components in future PRs. Would be great to add tests for the provider implementations and maybe some end-to-end scenarios for the turndown/turn-up cycle. Could also look into adding some concurrency stress tests and state transition validations for the more complex parts.
Let me know what you think! Happy to adjust these tests if needed.