Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skewer version to v0.0.19 (master) #7826

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rakechill
Copy link
Contributor

@rakechill rakechill commented Feb 11, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Updates a dependency version: https://github.com/Azure/skewer/releases/tag/v0.0.19
Already done for 1.27-1.31 release branches. Will follow this up with updating on 1.32.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot added area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @rakechill. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 11, 2025
@rakechill rakechill changed the title Update skewer version on master branch Update skewer version to v0.0.19 (master) Feb 11, 2025
@tallaxes
Copy link
Contributor

/lgtm
/approve

Already done for 1.27-1.31 release branches. Will follow this up with updating on 1.32.

@rakechill, please link to these PRs

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 11, 2025
@tallaxes
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 11, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2025
@rakechill
Copy link
Contributor Author

rakechill commented Feb 20, 2025

@tallaxes, @aleksandra-malinowska
I've updated this PR by:

  1. reverting my original commit
  2. running go get github.com/Azure/[email protected]. This properly updates skewer in go.mod + go.sum. The import statement is updated in azure_client.go due to it being incompatible with this newer version of skewer.

Previously, I ran go mod tidy which under the hood will update other dependencies, as well. This resulted in the dra dependency moving from indirect to direct.

I also have closed #7827 in favor of cherry-picking this into 1.32 via the bot.

@rakechill rakechill requested a review from tallaxes February 21, 2025 16:07
@tallaxes
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rakechill, tallaxes
Once this PR has been reviewed and has the lgtm label, please assign x13n for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tallaxes
Copy link
Contributor

Previously, I ran go mod tidy which under the hood will update other dependencies, as well. This resulted in the dra dependency moving from indirect to direct.

This actually sounds correct, though maybe a bit surprising it is not up to date on master. Does this happen without skewer update as well? If Yes, then please submit another PR with just go mod tidy update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cluster-autoscaler area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants